Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACS-6125: test support for path queries against categories #2602

Merged
merged 8 commits into from
Nov 23, 2023

Conversation

Pawel-608
Copy link
Contributor

No description provided.

@Pawel-608 Pawel-608 changed the title ACS-ACS-6125: test support for path queries against categories ACS-6125: test support for path queries against categories Oct 17, 2023
// then
STEP("Verify that searching by PATH for nested folder will return no results (Dependency to category is not transitive)");
SearchRequest query = req(format("PATH:'/cm:categoryRoot/cm:generalclassifiable/cm:%s/cm:%s/cm:%s/cm:%s'", Kname, Lname, Aname, Bname));
searchQueryService.expectResultsFromQuery(query, testUser);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a expectNoResultsFromQuery method that you can use for this.

Copy link
Member

@tpage-alfresco tpage-alfresco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few trivial things, but LGTM 👍

Pawel-608 and others added 2 commits October 23, 2023 12:42
…ch/reindexing/NodeWithCategoryIndexingTests.java

Co-authored-by: Tom Page <[email protected]>
…ch/reindexing/NodeWithCategoryIndexingTests.java

Co-authored-by: Tom Page <[email protected]>
@Pawel-608 Pawel-608 force-pushed the feature/ACS-3832-category-parent-query branch from 5373e08 to f68b8da Compare October 23, 2023 10:50
Base automatically changed from feature/ACS-3832-category-parent-query to master October 27, 2023 10:48
# Conflicts:
#	tests/tas-elasticsearch/src/test/java/org/alfresco/elasticsearch/reindexing/NodeWithCategoryIndexingTests.java
#	tests/tas-elasticsearch/src/test/java/org/alfresco/elasticsearch/reindexing/utils/Categories.java
#	tests/tas-elasticsearch/src/test/java/org/alfresco/elasticsearch/reindexing/utils/Category.java
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PMD found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@Pawel-608 Pawel-608 merged commit ea2511e into master Nov 23, 2023
61 checks passed
@Pawel-608 Pawel-608 deleted the feature/category-path-query branch November 23, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants